Skip TestWriteCgroupFileHandlesInterrupt on CentOS 7 #4099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 7 is showing its age and we'd rather skip some tests on it than find out why they are flaky. Add internal/testutil package, and move the generalized version of SkipOnCentOS7 from libcontainer/cgroups/devices to there. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It's flaky (kernel bug?) and there's probably nothing we can do about it. Fixes opencontainers#3418. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
skip-centos-7
branch
from
87350b9
to
b2539a7
Compare
AkihiroSuda
approved these changes
Oct 31, 2023
lifubang
approved these changes
Oct 31, 2023
This might be the kernel (as there are no processes in the cgroup... although it is still in a preparation state) -- but, for some reason, it only happens in CentOS 7, so maybe we just hit a kernel bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's flaky and we can do nothing about it.
Also, this is a chance to finally introduce our first
internalpackage (even if for tests only), discussed in #3028.Fixes #3418.